style attributes were not taken into account with innerHTML#21
Open
dmcinnes wants to merge 5 commits intothatcher:masterfrom
Open
style attributes were not taken into account with innerHTML#21dmcinnes wants to merge 5 commits intothatcher:masterfrom
dmcinnes wants to merge 5 commits intothatcher:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Guys,
It appears CSS2Properties was only looking at cssText of the element passed in, which was only the case with style nodes. I've extended CSS2Properties to also check the style attribute of the passed in node (but default to cssText if available).
Thanks,
Doug